adding icmp firewall rule crashes chunter

Description

If trying to add a icmp firewall rulle with no code it will crash chunter

>@chunter_vm_fsm:handle_event:762 [vm:054c97f6-f17a-4162-b6f1-2c7ebfd3ecf3(03f66e7b-16a0-42f6-a621-5f91017c5e2b)] Updating FW rules, adding [{block,[any],[{vm,<<"054c97f6-f17a-4162-b6f1-2c7ebfd3ecf3">>}],icmp,[{icmp,0,null}]}] deleting [].
2016-10-12 21:16:37.124 [warning] <0.514.0>@chunter_vm_fsm:terminate:1058 [terminate:054c97f6-f17a-4162-b6f1-2c7ebfd3ecf3] Terminating from running with reason {badarg,[{erlang,integer_to_list,[null],[]},{fwadm,build_filter_element,1,[{file,"/opt/local/go-agent/pipelines/Chunter-Rel/_build/prod/lib/chunter/src/fwadm.erl"},{line,275}]},{fwadm,build,1,[{file,"/opt/local/go-agent/pipelines/Chunter-Rel/_build/prod/lib/chunter/src/fwadm.erl"},{line,115}]},{fwadm,add,3,[{file,"/opt/local/go-agent/pipelines/Chunter-Rel/_build/prod/lib/chunter/src/fwadm.erl"},{line,24}]},{chunter_vm_fsm,'handle_event/3-lc$^2/1-2',3,[{file,"/opt/local/go-agent/pipelines/Chunter-Rel/_build/prod/lib/chunter/src/chunter_vm_fsm.erl"},{line,764}]},{chunter_vm_fsm,handle_event,3,[{file,"/opt/local/go-agent/pipelines/Chunter-Rel/_build/prod/lib/chunter/src/chunter_vm_fsm.erl"},{line,764}]},{gen_fsm,handle_msg,7,[{file,"gen_fsm.erl"},{line,518}]},{proc_lib,init_p_do_apply,3,[{file,"proc_lib.erl"},{line,239}]}]}.
2016-10-12 21:16:37.125 [warning] <0.514.0>@chunter_vm_fsm:terminate:1060 [terminate:054c97f6-f17a-4162-b6f1-2c7ebfd3ecf3] The state: {state,<<"56cd8dd2-71bc-4177-9563-984cab2c26fd">>,zone,zone,<<"054c97f6-f17a-4162-b6f1-2c7ebfd3ecf3">>,undefined,smartos,undefined,[{<<"lrc:/etc/rc2_d/S99net_tune">>,<<"legacy_run">>,<<"19:47:18">>},{<<"svc:/milestone/devices:default">>,<<"online">>,<<"19:47:15">>},{<<"svc:/milestone/multi-user-server:default">>,<<"online">>,<<"19:47:19">>},{<<"svc:/milestone/multi-user:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/milestone/name-services:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/milestone/network:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/milestone/single-user:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/milestone/sysconfig:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/network/datalink-management:default">>,<<"online">>,<<"19:47:14">>},{<<"svc:/network/dns/client:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/network/dns/install:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/dns/multicast:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/fifo_dns:default">>,<<"online">>,<<"21:00:02">>},{<<"svc:/network/inetd-upgrade:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/inetd:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/network/initial:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/network/install:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/ip-interface-management:default">>,<<"online">>,<<"19:47:14">>},{<<"svc:/network/ipfilter:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/ipqos:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/ipsec/ike:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/ipsec/ipsecalgs:default">>,<<"online">>,<<"19:47:15">>},{<<"svc:/network/ipsec/manual-key:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/ipsec/policy:default">>,<<"online">>,<<"19:47:15">>},{<<"svc:/network/iptun:default">>,<<"online">>,<<"19:47:17">>},{<<"svc:/network/ipv4-forwarding:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/ipv6-forwarding:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/ldap/client:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/loadbalancer/ilb:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/location:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/login:eklogin">>,<<"disabled">>,<<"19:47:18">>},{<<"svc:/network/login:klogin">>,<<"disabled">>,<<"19:47:19">>},{<<"svc:/network/login:rlogin">>,<<"disabled">>,<<"19:47:19">>},{<<"svc:/network/loopback:default">>,<<"online">>,<<"19:47:15">>},{<<"svc:/network/netcfg:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/netmask:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/nfs/cbd:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/nfs/client:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/nfs/mapid:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/nfs/nlockmgr:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/nfs/rquota:default">>,<<"disabled">>,<<"19:47:18">>},{<<"svc:/network/nfs/status:default">>,<<"disabled">>,<<"19:47:15">>},{<<"svc:/network/nis/client:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/physical:default">>,<<"online">>,<<"19:47:17">>},{<<"svc:/network/physical:nwam">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/rexec:default">>,<<"disabled">>,<<"19:47:19">>},{<<"svc:/network/routing-setup:default">>,<<"online">>,<<"19:47:18">>},{<<"svc:/network/routing/legacy-routing:ipv4">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/routing/legacy-routing:ipv6">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/routing/ndp:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/routing/rdisc:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/routing/ripng:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/routing/route:default">>,<<"disabled">>,<<"19:47:16">>},{<<"svc:/network/rpc/bind:default">>,<<"disabled">>,<<"19:47:14">>},{<<"svc:/network/rpc/gss:default">>,<<"disabled">>,<<"19:47:18">>},{<<"svc:/network/rpc/keyserv:...">>,...},...],...} .

Environment

None

Status

Assignee

Heinz N. Gies

Reporter

Kevin Meziere

Labels

None

Components

Fix versions

Affects versions

Priority

High
Configure