Deleting VM's with backups and s3 errors

Description

This is a bit of a tricky one.

When the s3 delete fails the delete command fails, neither option seems good

1) if we delete anyway we risk that we have abandoned files inside of s3
2) if we block the delete we can't delete VM's after a s3 crash.

This should be solved in a sensible manner, not sure which yet

Exception in FiFo Test Lab

unknown in sniffle@192.168.1.41
Process <0.32323.190> with 0 neighbors crashed with reason: {{aws_error,
{socket_error,
{failed_connect,
[{to_address,{"fifo-backups.192.168.1.42.xip.io",8443}},
{inet,[inet],etimedout}]}}},
[{erlcloud_s3,s3_request,8,
[{file,"/root/sniffle/_build/default/lib/erlcloud/src/erlcloud_s3.erl"},
{line,855}]},
{erlcloud_s3,delete_object,3,
[{file,"/root/sniffle/_build/default/lib/erlcloud/src/erlcloud_s3.erl"},
{line,203}]},
{sniffle_vm,'do_delete_backup/3-lc$^0/1-0',1,
[{file,"/root/sniffle/_build/default/lib/sniffle/src/sniffle_vm.erl"},
{line,1259}]},
{sniffle_vm,do_delete_backup,3,
[{file,"/root/sniffle/_build/default/lib/sniffle/src/sniffle_vm.erl"},
{line,1259}]},
{sniffle_vm,'finish_delete/1-lc$^0/1-0',3,
[{file,"/root/sniffle/_build/default/lib/sniffle/src/sniffle_vm.erl"},
{line,840}]},
{sniffle_vm,finish_delete,1,
[{file,"/root/sniffle/_build/default/lib/sniffle/src/sniffle_vm.erl"},
{line,840}]},
{sniffle_tcp_handler,message,2,
[{file,
"/root/sniffle/_build/default/lib/sniffle_api/src/sniffle_tcp_handler.erl"},
{line,449}]},
{mdns_server_protocol,handle_data,3,
[{file,
"/root/sniffle/_build/default/lib/mdns_server_lib/src/mdns_server_protocol.erl"},
{line,109}]}]}

View on Bugsnag

Stacktrace

View full stacktrace

Environment

None

Status

Assignee

Heinz N. Gies

Reporter

Bug Snag

Labels

None

Components

Fix versions

Priority

High
Configure